PFS/pfs-intra
4
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

#7 Perfil de Personal Administrativo - Listado de empleados #8

Merged
alex merged 6 commits from Rama-Ricardo into main 2024-08-27 19:17:53 +00:00
Conversation 0 Commits 6 Files Changed 5 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6fe875d062 - Show all commits

4
src/main/java/com/primefactorsolutions/model/Employee.java
View File

@ -17,7 +17,7 @@ import java.util.List;
@NoArgsConstructor @NoArgsConstructor
@EqualsAndHashCode(callSuper = true) @EqualsAndHashCode(callSuper = true)
public class Employee extends BaseEntity { public class Employee extends BaseEntity {
private String name; private String firstName;
jesus.pelaez marked this conversation as resolved Outdated
alex commented 2024-08-26 22:02:53 +00:00
Outdated
Review
Copy Link

mantener firstName para este campo para ser mas explicito.

mantener `firstName` para este campo para ser mas explicito.
jesus.pelaez commented 2024-08-27 13:44:08 +00:00
Outdated
Review
Copy Link

Cambio realizado, esperando para revisión

Cambio realizado, esperando para revisión
private String lastName; private String lastName;
private String status; private enum status { ACTIVE, INACTIVE};
jesus.pelaez marked this conversation as resolved Outdated
alex commented 2024-08-26 22:02:15 +00:00
Outdated
Review
Copy Link

definir un enum con los status ACTIVE, INACTIVE. en vez de usar un String.

definir un enum con los status ACTIVE, INACTIVE. en vez de usar un String.
jesus.pelaez commented 2024-08-27 13:43:49 +00:00
Outdated
Review
Copy Link

Cambio realizado, esperando para revisión

Cambio realizado, esperando para revisión
} }