PFS/pfs-intra
4
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

#7 Perfil de Personal Administrativo - Listado de empleados #8

Merged
alex merged 6 commits from Rama-Ricardo into main 2024-08-27 19:17:53 +00:00
Conversation 0 Commits 6 Files Changed 5 +162 -21
jesus.pelaez commented 2024-08-23 00:47:03 +00:00
Member
Copy Link
No description provided.
jesus.pelaez added 1 commit 2024-08-23 00:47:04 +00:00
jesus.pelaez requested review from alex 2024-08-23 00:48:20 +00:00
jesus.pelaez added this to the pfs-intra project 2024-08-23 00:48:37 +00:00
jesus.pelaez self-assigned this 2024-08-23 00:48:44 +00:00
jesus.pelaez added 1 commit 2024-08-23 00:52:02 +00:00
jesus.pelaez added 2 commits 2024-08-24 01:55:06 +00:00
alex requested changes 2024-08-26 22:03:03 +00:00
Dismissed
src/main/java/com/primefactorsolutions/model/Employee.java Outdated
@ -19,3 +19,2 @@
public class Employee extends BaseEntity {
private String username;
private String firstName;
private String name;
alex commented 2024-08-26 22:02:53 +00:00
Owner
Copy Link

mantener firstName para este campo para ser mas explicito.

mantener `firstName` para este campo para ser mas explicito.
jesus.pelaez commented 2024-08-27 13:44:08 +00:00
Author
Member
Copy Link

Cambio realizado, esperando para revisión

Cambio realizado, esperando para revisión
jesus.pelaez marked this conversation as resolved
src/main/java/com/primefactorsolutions/model/Employee.java Outdated
@ -28,3 +22,1 @@
@OneToMany(fetch = FetchType.EAGER, mappedBy = "employee", cascade = {CascadeType.ALL})
private List<Document> documents;
private Role role;
private String status;
alex commented 2024-08-26 22:02:15 +00:00
Owner
Copy Link

definir un enum con los status ACTIVE, INACTIVE. en vez de usar un String.

definir un enum con los status ACTIVE, INACTIVE. en vez de usar un String.
jesus.pelaez commented 2024-08-27 13:43:49 +00:00
Author
Member
Copy Link

Cambio realizado, esperando para revisión

Cambio realizado, esperando para revisión
jesus.pelaez marked this conversation as resolved
jesus.pelaez added 1 commit 2024-08-27 13:41:20 +00:00
jesus.pelaez added 1 commit 2024-08-27 15:13:21 +00:00
alex approved these changes 2024-08-27 19:13:39 +00:00
alex merged commit f749146755 into main 2024-08-27 19:17:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alex
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
pfs-intra
Assignees
Clear assignees
No Assignees
jesus.pelaez
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PFS/pfs-intra#8
No description provided.
Delete Branch "Rama-Ricardo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?