PFS/pfs-intra
4
0
Fork 0
Code Issues 32 Pull Requests Actions Packages Projects 2 Releases Wiki Activity

#4-Registro-de-Información-Personal #16

Merged
alex merged 15 commits from #4-Registro-de-Información-Personal into main 2024-09-08 13:08:42 +00:00
Conversation 0 Commits 15 Files Changed 3 +109 -5
melina.gutierrez commented 2024-09-06 14:36:01 +00:00
Member
Copy Link
No description provided.
melina.gutierrez added 11 commits 2024-09-06 14:36:02 +00:00 
# Conflicts:
#	src/main/java/com/primefactorsolutions/model/Employee.java
#	src/main/java/com/primefactorsolutions/service/EmployeeService.java
#	src/main/java/com/primefactorsolutions/views/EmployeeView.java
#	src/main/java/com/primefactorsolutions/views/EmployeesListView.java
alex requested changes 2024-09-06 14:55:20 +00:00
src/main/java/com/primefactorsolutions/views/EmployeesListView.java Outdated
@ -45,2 +45,4 @@
addEditButtonColumn("Edit", this::navigateToEditView);
setupPagingGrid();
table.addItemDoubleClickListener(event -> {
alex commented 2024-09-06 14:53:29 +00:00
Owner
Copy Link

no es necesario agregar esto porque ya existe el boton edit que navega a la vista edit.

no es necesario agregar esto porque ya existe el boton edit que navega a la vista edit.
alex marked this conversation as resolved
src/main/java/com/primefactorsolutions/views/EmployeesListView.java Outdated
@ -80,6 +85,8 @@ public class EmployeesListView extends Main {
}
private void refreshGrid() {
List<Employee> employees = employeeService.getEmployeeRepository().findAll();
alex commented 2024-09-06 14:55:15 +00:00
Owner
Copy Link

no es una buena practica acceder a las dependencies del service. Veo que aca el problema es que la clase EmployeeService tiene anotacion @Data. Porfavor quitar la anotacion @Data de EmployeeService y crear metodo findAllEmployees si es necesario.

PERO por que es necesario cargar TODOS los empleados aca? la tabla ya carga los empleados con paginacion.

no es una buena practica acceder a las dependencies del service. Veo que aca el problema es que la clase EmployeeService tiene anotacion @Data. Porfavor quitar la anotacion @Data de EmployeeService y crear metodo findAllEmployees si es necesario. PERO por que es necesario cargar TODOS los empleados aca? la tabla ya carga los empleados con paginacion.
melina.gutierrez marked this conversation as resolved
melina.gutierrez added 2 commits 2024-09-07 21:34:12 +00:00 
# Conflicts:
#	src/main/java/com/primefactorsolutions/views/EmployeeView.java
melina.gutierrez added 1 commit 2024-09-08 12:06:27 +00:00
melina.gutierrez added 1 commit 2024-09-08 12:26:15 +00:00
melina.gutierrez requested review from alex 2024-09-08 12:27:10 +00:00
alex merged commit ccb3629409 into main 2024-09-08 13:08:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alex
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: PFS/pfs-intra#16
No description provided.
Delete Branch "#4-Registro-de-Información-Personal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?